Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve linter empty_migration_scripts #255

Closed

Conversation

jbelle
Copy link
Contributor

@jbelle jbelle commented Dec 3, 2024

Changes the linter empty_migration_scripts to also detect migrations which only contain empty lines, comments or commented out code.

The linter now also detects migrations which only contain empty lines, comments
or commented out code
Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am surprised there is no builtin method to check for empty statement lists.

@danielratiu
Copy link
Member

The CI fails, I have opened another PR with this commit and the CI works fine - #258

I am closing this one

@danielratiu danielratiu closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants