feat: open window (from drag) under mouse

src/services/drag-and-drop.actions.ts

@@ -1191,6 +1191,13 @@ export function resetOther(): void {
 
 let dragEndedRecentlyTimeout: number | undefined
 
+let relativeMouseX = 0
+let relativeMouseY = 0
+export function onDragStart(e: DragEvent): void {
+  relativeMouseX = e.clientX
+  relativeMouseY = e.clientY + (window.outerHeight - window.innerHeight) //account for window height
+}
+
 export async function onDragEnd(e: DragEvent): Promise<void> {
   resetDragPointer()
   DnD.resetOther()
@@ -1237,13 +1244,28 @@ export async function onDragEnd(e: DragEvent): Promise<void> {
       return
     }
 
+    const mouseX = e.screenX
+    const mouseY = e.screenY
+    let maximized = false
+    await browser.windows.getCurrent().then(function (window) {
+      if (window.state === 'maximized') {
+        maximized = true
+      }
+    })
     const fromTabs = info.type === DragType.Tabs
     const fromTabsPanel = info.type === DragType.TabsPanel
     const fromBookmarks = info.type === DragType.Bookmarks
     const fromBookmarksPanel = info.type === DragType.BookmarksPanel
 
     if (fromTabs && info.items?.length) {
-      const dst = { windowId: NEWID, incognito: Windows.incognito, panelId: info.panelId }
+      const dst = {
+        windowId: NEWID,
+        incognito: Windows.incognito,
+        panelId: info.panelId,
+        top: mouseY - relativeMouseY,
+        left: mouseX - relativeMouseX,
+        maximized: maximized,
+      }
       if (mode === 'copy') Tabs.open(info.items, dst)
       else Tabs.move(info.items, {}, dst)
     }

src/services/tabs.fg.move.ts

@@ -12,6 +12,7 @@ import * as IPC from 'src/services/ipc'
 import * as Popups from 'src/services/popups'
 import * as Logs from 'src/services/logs'
 import * as Utils from 'src/utils'
+import WindowState = browser.windows.WindowState
 
 export async function move(
   tabsInfo: DeepReadonly<ItemInfo[]>,
@@ -57,7 +58,14 @@ export async function move(
   if (dst.windowId === NEWID) {
     Tabs.detachTabs(tabsInfo.map(t => t.id))
     const info = Utils.cloneArray<ItemInfo>(tabsInfo)
-    const conf = { incognito: dst.incognito, tabId: MOVEID }
+    const windowState = (dst.maximized === true ? 'maximized' : 'normal') as WindowState
+    const conf = {
+      incognito: dst.incognito,
+      tabId: MOVEID,
+      top: dst.top,
+      left: dst.left,
+      state: windowState,
+    }
     info.forEach(t => (t.panelId = dst.panelId))
     IPC.bg('createWindowWithTabs', info, conf).finally(() => Tabs.detachingTabIds.clear())
     return

src/services/windows.actions.ts

@@ -150,7 +150,24 @@ export async function createWithTabs(
   const defaultContainerId = conf.incognito ? PRIVATE_CONTAINER_ID : DEFAULT_CONTAINER_ID
   let window: browser.windows.Window
   try {
-    window = await browser.windows.create(conf)
+    if (conf.state === 'maximized') {
+      let screenWidth = 800
+      let screenHeight = 600
+      await browser.windows.getCurrent().then(win => {
+        screenWidth = win.width ?? screenWidth
+        screenHeight = win.height ?? screenHeight
+      })
+      conf.state = 'normal' //open in normal state to avoid maximized window in the wrong screen
+      conf.width = screenWidth / 2 //if not set, the window will attempt to open maximized on the wrong screen
+      conf.height = screenHeight / 2
+      window = await browser.windows.create(conf)
+      if (window.id) {
+        //immediately maximize the window after creation
+        await browser.windows.update(window.id, { state: 'maximized' })
+      }
+    } else {
+      window = await browser.windows.create(conf)
+    }
   } catch (err) {
     if (String(err) === 'Error: Extension does not have permission for incognito mode') {
       if (Windows.lastFocusedWinId !== undefined) {

src/sidebar/sidebar.vue

@@ -22,6 +22,7 @@
   :data-search="!!Search.reactive.value"
   :data-sticky-bookmarks="Settings.state.pinOpenedBookmarksFolder"
   :data-colorized-branches="Settings.state.colorizeTabsBranches"
+  @dragstart="DnD.onDragStart"
   @dragend="DnD.onDragEnd"
   @dragenter="DnD.onDragEnter"
   @dragleave="DnD.onDragLeave"

src/types.ts

@@ -214,6 +214,9 @@ export interface DstPlaceInfo {
   containerId?: string
   windowId?: ID
   incognito?: boolean
+  left?: number
+  top?: number
+  maximized?: boolean
   windowChooseConf?: WindowChoosingDetails
   discarded?: boolean
 }