Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the ability to cycle through panels (hidden configurable) #1829

Open
wants to merge 2 commits into
base: v5
Choose a base branch
from

Conversation

seppulcro
Copy link

@seppulcro seppulcro commented Oct 10, 2024

Hi, I've added the ability to cycle through panels infinitely, with an option do go through hidden panels as well.

Solves #686

output.webm

@ChilledMoth
Copy link
Contributor

Nice, but why are you taking over the default hotkey for 'Open a new tab after the active tab'?

Just leave it undefined or set a new one, idk, 'Alt+M' or something (since 'Alt-Comma' and 'Alt+Period' are the defaults for 'Switch to previous panel' and 'Switch to next panel', respectively).

@seppulcro
Copy link
Author

Nice, but why are you taking over the default hotkey for 'Open a new tab after the active tab'?

Just leave it undefined or set a new one, idk, 'Alt+M' or something (since 'Alt-Comma' and 'Alt+Period' are the defaults for 'Switch to previous panel' and 'Switch to next panel', respectively).

Whoops sorry I've been using that since I've setup it up and must've forgot to change it back.

I've also noticed a typo that I've fixed, and since I started using it for myself yesterday the ability to go only forwards didn't seem enough... so I added the ability to go backwards too in the latest commit.

@seppulcro
Copy link
Author

@ChilledMoth please re-validate when you have the time so I know if it's up to spec now 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants