Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Add tripID field to glides trip_updates ingestion #458

Merged
merged 1 commit into from
Oct 25, 2024
Merged

FEAT: Add tripID field to glides trip_updates ingestion #458

merged 1 commit into from
Oct 25, 2024

Conversation

rymarczy
Copy link
Collaborator

Ingest new tripId field from Glides kinesis stream. This field is flattened into it's own column, so merging with existing datasets should cause no issues.

Asana Task: https://app.asana.com/0/1205827492903547/1208481082941326

@rymarczy rymarczy requested review from arkadyan and removed request for arkadyan October 25, 2024 15:29
@github-actions GitHub Actions
Copy link

Coverage of commit daa0ff0

Summary coverage rate:
  lines......: 75.4% (2491 of 3304 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@rymarczy rymarczy requested a review from arkadyan October 25, 2024 15:34
arkadyan
arkadyan approved these changes Oct 25, 2024
View reviewed changes
Copy link

@arkadyan arkadyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rymarczy rymarczy merged commit b67232c into main Oct 25, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadyan arkadyan arkadyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rymarczy @arkadyan