Jvc android search recent stops #622

JackVCurtis · 2025-01-06T14:53:01Z

What is this PR for?

When there is no query entered in the Search view, shows a list of recently visited stops.

iOS

If you added any user-facing strings on iOS, are they included in Localizable.xcstrings?
- Add temporary machine translations, marked "Needs Review"

android

All user-facing strings added to strings resource
Expensive calculations are run in withContext(Dispatchers.Default) where possible

What testing have you done?
Updated unit tests for affected views.

androidApp/src/main/java/com/mbta/tid/mbta_app/android/search/SearchBarOverlay.kt

androidApp/src/main/res/values/strings.xml

androidApp/src/main/java/com/mbta/tid/mbta_app/android/state/getSearchResults.kt

…y error

JackVCurtis requested a review from a team as a code owner January 6, 2025 14:53

JackVCurtis requested a review from boringcactus January 6, 2025 14:53

JackVCurtis force-pushed the jvc-android-search-recent-stops branch from 2171d3f to 9677c2e Compare January 6, 2025 15:39

boringcactus reviewed Jan 6, 2025

View reviewed changes

JackVCurtis added 8 commits January 7, 2025 10:01

Add recent stops to populate empty search results

3603abb

fix results shape when only one result

8fc3d49

fix string literals

9a73ed9

fix tests

9ae6f7a

hopefully fix ci failure

43d371f

use visible instead of expanded to invalidate search results, fix cop…

52acaac

…y error

only debounce if query is not empty

5c02e14

fix test to use correct copy

5afa264

JackVCurtis force-pushed the jvc-android-search-recent-stops branch from 9677c2e to 5afa264 Compare January 7, 2025 15:11

boringcactus approved these changes Jan 7, 2025

View reviewed changes

Provide feedback