Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: deploy to dev-orange with PR label #11

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

boringcactus
Copy link
Member

@boringcactus boringcactus commented Nov 15, 2023

As requested, this sets up automatic deployments to dev-orange based on a PR label. It also adds a somewhat nicer run title for manual deploys, since that overlaps somewhat with having a nice message in Slack describing what was deployed (which turns out to be surprisingly annoying when what's deployed is a PR).

Since this repo will at some point become public, we may eventually need to ensure that this only gets run for PRs that we wrote ourselves, even if we aren't quite paying attention and we apply the label to a PR coming in from outside. I'm not sure how best to do that, though.

I wish very much that GitHub Actions used a real programming language with actual conditionals and local variables.

@boringcactus boringcactus added the deploy to dev-orange Automatically deploy this PR to dev-orange label Nov 15, 2023
@boringcactus boringcactus marked this pull request as ready for review November 15, 2023 17:31
@boringcactus boringcactus requested a review from a team November 15, 2023 17:31
@@ -1,4 +1,5 @@
name: Deploy to Staging
run-name: ${{ github.event_name == 'workflow_dispatch' && format('Deploy {0} {1} to Staging', github.ref_type, github.ref_name) || '' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@boringcactus boringcactus merged commit 5198759 into main Nov 15, 2023
6 checks passed
@boringcactus boringcactus deleted the mth-dev-orange-label branch November 15, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy to dev-orange Automatically deploy this PR to dev-orange
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants