Skip to content

Commit

Permalink
fix: keep inline_alerts field for compatibility
Browse files Browse the repository at this point in the history
Currently deployed client code (in particular DUPs, which have to be
updated manually by sending a new package to our vendor) requires this
field to be present or it will crash.
  • Loading branch information
digitalcora committed Nov 21, 2024
1 parent 6028992 commit 28474f8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
4 changes: 3 additions & 1 deletion lib/screens/v2/widget_instance/departures.ex
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,9 @@ defmodule Screens.V2.WidgetInstance.Departures do
type: :departure_row,
route: serialize_route(departures, route_pill_serializer),
headsign: serialize_headsign(departures, screen),
times_with_crowding: serialize_times_with_crowding(departures, screen, now)
times_with_crowding: serialize_times_with_crowding(departures, screen, now),
# Temporarily retained for compatibility with deployed clients that expect this value
inline_alerts: []
}
end

Expand Down
1 change: 0 additions & 1 deletion test/screens/v2/departure_test.exs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
defmodule Screens.V2.DepartureTest do
use ExUnit.Case, async: true

alias Screens.Alerts.Alert
alias Screens.Routes.Route
alias Screens.Predictions.Prediction
alias Screens.Schedules.Schedule
Expand Down
1 change: 0 additions & 1 deletion test/screens/v2/widget_instance/departures_test.exs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
defmodule Screens.V2.WidgetInstance.DeparturesTest do
use ExUnit.Case, async: true

alias Screens.Alerts.Alert
alias ScreensConfig.V2.Departures.Header
alias ScreensConfig.V2.Departures.Layout
alias ScreensConfig.V2.FreeTextLine
Expand Down

0 comments on commit 28474f8

Please sign in to comment.