Swap screen_ids handler clauses & remove redundant guard

mbta · Sep 14, 2023 · 5e78b54 · 5e78b54
1 parent 4b1d057
commit 5e78b54
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/lib/screens/config/state.ex b/lib/screens/config/state.ex
@@ -174,8 +174,11 @@ defmodule Screens.Config.State do
     {:reply, app_params, state}
   end
 
-  def handle_call({:screen_ids, filter_fn}, _from, %__MODULE__{config: config} = state)
-      when is_function(filter_fn, 1) do
+  def handle_call({:screen_ids, nil}, _from, %__MODULE__{config: config} = state) do
+    {:reply, Map.keys(config.screens), state}
+  end
+
+  def handle_call({:screen_ids, filter_fn}, _from, %__MODULE__{config: config} = state) do
     ids =
       config.screens
       |> Enum.filter(filter_fn)
@@ -184,10 +187,6 @@ defmodule Screens.Config.State do
     {:reply, ids, state}
   end
 
-  def handle_call({:screen_ids, _}, _from, %__MODULE__{config: config} = state) do
-    {:reply, Map.keys(config.screens), state}
-  end
-
   def handle_call({:mode_disabled?, mode}, _from, %__MODULE__{config: config} = state) do
     %Devops{disabled_modes: disabled_modes} = config.devops