Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Send and log version in data requests from OFM clients #1843

Merged
merged 2 commits into from
Aug 31, 2023
Merged

feat: Send and log version in data requests from OFM clients #1843

merged 2 commits into from
Aug 31, 2023

Conversation

jzimbel-mbta
Copy link
Member

Asana task: Include version param in data requests from OFM client apps

Quick 'n simple 😎

  • Tests added?

@jzimbel-mbta jzimbel-mbta requested review from a team and PaulJKim and removed request for a team August 30, 2023 21:44
@github-actions
Copy link

Coverage of commit 0a3a50a

Summary coverage rate:
  lines......: 41.0% (2287 of 5578 lines)
  functions..: 42.3% (1047 of 2474 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/log_screen_data.ex                                           | 4.2%     48| 9.5%    21|    -      0
  lib/screens_web/controllers/v2/screen_api_controller.ex                  | 0.0%     41| 0.0%    14|    -      0

Download coverage report

@jzimbel-mbta jzimbel-mbta merged commit 6f5753f into master Aug 31, 2023
4 checks passed
@jzimbel-mbta jzimbel-mbta deleted the jz/ofm-clients-send-version-in-data-requests branch August 31, 2023 18:18
hannahpurcell pushed a commit that referenced this pull request Sep 1, 2023
@jzimbel-mbta @hannahpurcell
feat: Send and log version in data requests from OFM clients (#1843)
d84ba10 
* Send and log version in data requests from OFM clients

* Always include logging params for triptych, even if we fail to determine pane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulJKim PaulJKim PaulJKim approved these changes

Assignees

@PaulJKim PaulJKim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzimbel-mbta @PaulJKim