Add a new log fn for unrecognized triptych player name #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzimbel-mbta
requested review from
a team and
cmaddox5
and removed request for
a team
Coverage of commit
|
cmaddox5
approved these changes
Aug 31, 2023
hannahpurcell
pushed a commit
that referenced
this pull request
Sep 1, 2023
hannahpurcell
added a commit
that referenced
this pull request
Sep 5, 2023
* Test PSAs uploaded, to be replaced * New local evergreen widget backend * Split-pane support for triptychs frontend * Make conversion of filename to slot_name more robust; pluralize config key * Seed :rand with current time / 15 * Evergreen takes conditional prop for video playing * Hook determines if app is onscreen to decide if video should be playing * feat: Add admin config columns (thus far) for triptych app (#1841) * fix: Handle unrecognized screen IDs in `screen_name_for_id` (#1842) * Send and log version in data requests from OFM clients * Always include logging params for triptych, even if we fail to determine pane * Add a new log fn for unrecognized triptych player name (#1844) * Accommodate various psa file types * Log when PSA file retrieval fails * Use stricter positioning for the panes * Added new config boolean to allow for conditionally display version and playername. * Added a couple of font mixins. * Added identifiers to TrainCrowding. * Added an EvergreenContent component for Triptychs. Just a wrapper of the OG with identifiers. * Allowed props to only change when needed. * Changed where identifiers are rendered for PSAs. * Add remaining admin columns for triptych config * Fix header font color for crowding widget (#1848) * Bring box-shadow of key to foreground (#1849) * Default to first folder of psas if needed * Set evergreen image size * Replace test psas with real ones --------- Co-authored-by: Christian Maddox <[email protected]> Co-authored-by: Jon Zimbel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana task: ad hoc?
This just adds and uses a
log_unrecognized_triptych_playerfunction. The rest of the changes are from my adding an alias + the formatter adjusting indentation.