Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lowercase "d" in "No data" label #1852

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix: Lowercase "d" in "No data" label #1852

merged 1 commit into from
Sep 5, 2023

Conversation

jzimbel-mbta
Copy link
Member

Asana task: ad hoc / polish

Prettier made some formatting changes. The only real change is "D" -> "d" on line 250.

  • Tests added?

@jzimbel-mbta jzimbel-mbta requested review from a team and hannahpurcell and removed request for a team September 5, 2023 16:16
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Coverage of commit c9c2f3d

Summary coverage rate:
  lines......: 40.8% (2287 of 5612 lines)
  functions..: 42.1% (1047 of 2486 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@jzimbel-mbta
Copy link
Member Author

@hannahpurcell feel free to merge when you review this, I've got notifications disabled until 3:30

hannahpurcell
hannahpurcell approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@hannahpurcell hannahpurcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah 👍

@jzimbel-mbta jzimbel-mbta merged commit 2862d86 into master Sep 5, 2023
@jzimbel-mbta jzimbel-mbta deleted the jz/lowercase-train-crowding-legend-label branch September 5, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahpurcell hannahpurcell hannahpurcell approved these changes

Assignees

@jzimbel-mbta jzimbel-mbta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzimbel-mbta @hannahpurcell