tweak(triptych): Do not render slots outside the viewport when using the 3-slot split layout #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzimbel-mbta
requested review from
a team and
cmaddox5
and removed request for
a team
cmaddox5
reviewed
Sep 7, 2023
|
|
||
| return ( | ||
| <> | ||
| {isInViewport(triptychPane) && ( |
There was a problem hiding this comment.
Could this viewport logic actually live above this in triptych_three_pane? We have access to what we need there too so could just make this a layout change instead of a widget change.
There was a problem hiding this comment.
Oh duh, yeah I think it could go there. I would just need to make sure that the middle and left screens still draw in the right positions if the left is not rendered.
Will make this change and then reassign you.
There was a problem hiding this comment.
So much simpler now, thanks for pointing that out.
Coverage of commit
|
…the 3-slot split layout
jzimbel-mbta
force-pushed
the
jz/triptych-prevent-offscreen-videos
branch
from
e854b39 to
b2074f2
Compare
cmaddox5
approved these changes
Sep 7, 2023
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana task: ad hoc
Panes besides the displayed one now only render the identifiers, just in case something has gone really wrong and we're seeing those for some reason. (Plus, they aren't expensive to render)
Screenshot 👇 notice that the
.left-paneand.right-paneelements have no children since they are outside the viewport.