fix: nil check in logging conditional #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaddox5
requested review from
a team and
PaulJKim
and removed request for
a team
Coverage of commit
|
PaulJKim
approved these changes
Sep 11, 2023
| @@ -56,7 +56,7 @@ defmodule Screens.V2.CandidateGenerator.Widgets.TrainCrowding do | |||
| params |> Map.to_list() |> fetch_alerts_fn.() do | |||
| next_train_prediction = List.first(predictions) | |||
|
|
|||
| if logging_options.is_real_screen do | |||
| if not is_nil(next_train_prediction) and logging_options.is_real_screen do | |||
There was a problem hiding this comment.
nit: I personally like if next_train_prediction && logging_options.is_real_screen do better for the brevity, but just personal preference. Not sure if using is_nil/1 is more idiomatic though
There was a problem hiding this comment.
I could've sworn I tried that earlier, but the problem is I was using and instead of &&... Thanks for the suggestion cause I definitely like this better.
Coverage of commit
|
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana task: ad-hoc
I forgot to check
next_train_predictionfornilwhen logging. This is causing a good amount of errors overnight when all predictions arenil.