tweak: Exclude triptychs from self-refresh job; Move unrelated logic out of Screens.Config.State

[jzimbel-mbta]

Asana task: ad hoc

In preparation for triptychs appearing in Screenplay, this prevents the screens-by-alert self refresh job from wasting effort on triptychs since they never show alerts and are likely to load less frequently than the cache TTL.

👉 I tried to put the list of non-alert-showing screen types in a high visibility spot, since we'll need to keep it manually updated. (I couldn't think of a simple programmatic way to determine whether a given screen can show alert widgets.)
I'm very open to suggestions on this, though. Either a way to make the list even more visible, or a way to automatically determine this screen type trait.

• Tests added?

[github-actions]

Coverage of commit fa31ce1

Summary coverage rate:
  lines......: 40.7% (2294 of 5632 lines)
  functions..: 42.1% (1050 of 2495 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/config/screen.ex                                             |71.4%     21|66.7%     9|    -      0
  lib/screens/config/state.ex                                              |19.0%     63|28.6%    35|    -      0
  lib/screens/screens_by_alert/self_refresh_runner.ex                      |15.0%     20|50.0%     6|    -      0
  lib/screens/v2/screen_data/parameters.ex                                 |30.0%     10|60.0%     5|    -      0

Download coverage report

[github-actions]

Coverage of commit 4b1d057

Summary coverage rate:
  lines......: 40.7% (2294 of 5632 lines)
  functions..: 42.1% (1050 of 2495 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/config/screen.ex                                             |71.4%     21|66.7%     9|    -      0
  lib/screens/config/state.ex                                              |19.0%     63|28.6%    35|    -      0
  lib/screens/screens_by_alert/self_refresh_runner.ex                      |15.0%     20|50.0%     6|    -      0
  lib/screens/v2/screen_data/parameters.ex                                 |30.0%     10|60.0%     5|    -      0

Download coverage report

[PaulJKim]

One minor comment, but otherwise looks good

[github-actions]

Coverage of commit 5e78b54

Summary coverage rate:
  lines......: 40.7% (2294 of 5632 lines)
  functions..: 42.1% (1050 of 2495 functions)
  branches...: no data found

Files changed coverage rate:
                                                                           |Lines       |Functions  |Branches    
  Filename                                                                 |Rate     Num|Rate    Num|Rate     Num
  ===============================================================================================================
  lib/screens/config/screen.ex                                             |71.4%     21|66.7%     9|    -      0
  lib/screens/config/state.ex                                              |19.0%     63|28.6%    35|    -      0
  lib/screens/screens_by_alert/self_refresh_runner.ex                      |15.0%     20|50.0%     6|    -      0
  lib/screens/v2/screen_data/parameters.ex                                 |30.0%     10|60.0%     5|    -      0

Download coverage report