tweak: Include triptych player name in data request logs #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzimbel-mbta
requested review from
a team and
cmaddox5
and removed request for
a team
cmaddox5
reviewed
Sep 18, 2023
| @@ -24,6 +24,7 @@ defmodule ScreensWeb.V2.ScreenApiController do | |||
| screen_side = params["screen_side"] | |||
| rotation_index = params["rotation_index"] | |||
| triptych_pane = params["pane"] | |||
| triptych_player_name = params["player_name"] | |||
There was a problem hiding this comment.
If we ever want to log DUP player names, we may want to consider renaming these params on the client. Just a thought, can't do that now.
There was a problem hiding this comment.
Oh hmm, we could... I could re-key the param over in show_triptych/2 before passing off to show/2.
There was a problem hiding this comment.
Totally up to you. I think it will only be unclear once we add player name to params for DUPs. But I don't see us needing to do that in the near future.
There was a problem hiding this comment.
I'll leave it be for now.
cmaddox5
approved these changes
Sep 18, 2023
jzimbel-mbta
deleted the
jz/log-triptych-player-name-in-data-request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana task: ad hoc
This will help us match up logs with real screens, and make sure that the placement of each player matches up with what OFM's station maps said.