fix: missing route pills on Solari screens #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactor of this logic to address type errors in 1f411cb was incorrect and ended up breaking text route pills (e.g. bus numbers, commuter rail track numbers). The variable mistakenly named `routeImg` here was intended to be an image-or-string.
digitalcora
requested review from
a team and
jzimbel-mbta
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor of this logic to address type errors in 1f411cb was incorrect and ended up breaking text route pills (e.g. bus numbers, commuter rail track numbers). The variable mistakenly named
routeImghere was intended to be an image-or-string.