fix: refactor of routes-serving-stop fetching #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of this function prior to the refactor in 297c302 returned only a list of routes, returning an empty list if an error occurred. The moved/renamed version returns an `:ok` tuple or `:error`, consistent with other data fetching functions, but the call sites were not updated to reflect this, and no tests failed because the mocks for the function still used the old return type (or, in the case of `ElevatorClosures`, the module lacked any tests at all). This keeps the return type of the fetching function the same, so errors can be distinguished if needed, but changes the existing call sites to perform the "default to empty list" logic themselves, so there should be no change in behavior.
Coverage of commit
|
sloanelybutsurely
approved these changes
Aug 1, 2024
Comment on lines
+69
to
+74
| defp routes_serving_stop(stop_id) do | ||
| case Route.serving_stop(stop_id) do | ||
| {:ok, routes} -> routes | ||
| :error -> [] | ||
| end | ||
| end |
There was a problem hiding this comment.
off-topic: maybe someday we'll have something like fromMaybe from Data.Maybe... :: sigh ::
There was a problem hiding this comment.
Can I interest you in some Gleam? 😺
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of this function prior to the refactor in 297c302 returned only a list of routes, returning an empty list if an error occurred. The moved/renamed version returns an
:oktuple or:error, consistent with other data fetching functions, but the call sites were not updated to reflect this (😓), and no tests failed because the mocks for the function still used the old return type (or, in the case ofElevatorClosures, the module lacked any tests at all).This keeps the return type of the fetching function the same, so errors can be distinguished if needed, but changes the existing call sites to perform the "default to empty list" logic themselves, so there should be no change in behavior.
Deployed this branch to dev-green so we should see errors if there are still any, from the self-refresh runner.