Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: in-memory Alert storage #2121

Merged
merged 1 commit into from
Aug 2, 2024
Merged

feat: in-memory Alert storage #2121

merged 1 commit into from
Aug 2, 2024

Conversation

sloanelybutsurely
Copy link
Contributor

Uses ServerSentEventStage to consume alerts events from the V3 API and store them in an ETS table keyed by alert ID.

@sloanelybutsurely sloanelybutsurely requested a review from a team as a code owner August 1, 2024 18:49
@sloanelybutsurely sloanelybutsurely mentioned this pull request Aug 1, 2024
Closed
panentheos
panentheos reviewed Aug 2, 2024
View reviewed changes
lib/screens/streams.ex Outdated Show resolved Hide resolved
panentheos
panentheos approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@panentheos panentheos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See a few small comments, then looks good.

@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-woqzvnlprlmq branch from e51146b to 7d020b5 Compare August 2, 2024 15:04
@sloanelybutsurely
feat: in-memory Alert storage
9f3b684 
Uses ServerSentEventStage to consume alerts events from the V3 API and
store them in an ETS table keyed by alert ID.
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-woqzvnlprlmq branch from 7d020b5 to 9f3b684 Compare August 2, 2024 15:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

Coverage of commit 9f3b684

Summary coverage rate:
  lines......: 45.0% (2959 of 6570 lines)
  functions..: 40.3% (1057 of 2623 functions)
  branches...: no data found

Files changed coverage rate:
                                                                          |Lines       |Functions  |Branches    
  Filename                                                                |Rate     Num|Rate    Num|Rate     Num
  ==============================================================================================================
  lib/screens/alerts/cache.ex                                             | 0.0%     22| 0.0%     9|    -      0
  lib/screens/application.ex                                              |75.0%      4|50.0%     2|    -      0
  lib/screens/streams/alerts.ex                                           |50.0%     10| 100%     4|    -      0

Download coverage report

@mbta mbta deleted a comment from github-actions bot Aug 2, 2024
@sloanelybutsurely sloanelybutsurely merged commit 41a1a7e into main Aug 2, 2024
11 checks passed
@sloanelybutsurely sloanelybutsurely deleted the sloane/push-woqzvnlprlmq branch August 2, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panentheos panentheos panentheos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sloanelybutsurely @panentheos