Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to in-memory Alerts cache instead of V3 API #2122

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

sloanelybutsurely
Copy link
Contributor

@sloanelybutsurely sloanelybutsurely commented Aug 1, 2024

Relies on the in-memory Alerts cache when a request for Alerts data has filters supported by the cache. Uses the existing V3 API client otherwise.


@sloanelybutsurely sloanelybutsurely requested a review from a team as a code owner August 1, 2024 20:05
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from ac89bd5 to 4685081 Compare August 1, 2024 20:07
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from 4685081 to c75755a Compare August 2, 2024 15:04
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-mzslqxkoqqzx branch 2 times, most recently from 88bc38d to 2c9a9ff Compare August 2, 2024 15:05
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from c75755a to 8a12984 Compare August 2, 2024 15:05
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-mzslqxkoqqzx branch from 2c9a9ff to 9e93440 Compare August 2, 2024 15:11
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from 8a12984 to 247db85 Compare August 2, 2024 15:11
@mbta mbta deleted a comment from github-actions bot Aug 2, 2024
@mbta mbta deleted a comment from github-actions bot Aug 2, 2024
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from 247db85 to 579c240 Compare August 2, 2024 18:52
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-mzslqxkoqqzx branch from 9e93440 to 4f587ae Compare August 2, 2024 18:52
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from 579c240 to 27bd32d Compare August 2, 2024 20:29
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-mzslqxkoqqzx branch from 4f587ae to fbc3f84 Compare August 2, 2024 20:29
@mbta mbta deleted a comment from github-actions bot Aug 2, 2024
@mbta mbta deleted a comment from github-actions bot Aug 2, 2024
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-mzslqxkoqqzx branch from fbc3f84 to 0968bfc Compare August 7, 2024 13:32
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch 2 times, most recently from 388196d to 4100315 Compare August 7, 2024 16:16
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-mzslqxkoqqzx branch from 0968bfc to f24f632 Compare August 7, 2024 16:16
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from 4100315 to 325874e Compare August 12, 2024 18:26
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-mzslqxkoqqzx branch from f24f632 to dc153c2 Compare August 12, 2024 18:26
Base automatically changed from sloane/push-mzslqxkoqqzx to main August 12, 2024 18:38
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from 325874e to 92af59a Compare August 15, 2024 14:43
@sloanelybutsurely sloanelybutsurely changed the base branch from main to sloane/push-mlqpqmzwwlru August 15, 2024 14:43
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-mlqpqmzwwlru branch from f780739 to cbf1d8a Compare August 15, 2024 21:21
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch 2 times, most recently from 5abfc19 to 9b10936 Compare August 15, 2024 21:21
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch 2 times, most recently from 94ce55d to fda8c66 Compare August 16, 2024 15:30
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-mlqpqmzwwlru branch from a30b74f to b6c369c Compare August 16, 2024 15:30
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch 2 times, most recently from 883b9e6 to 3f5ec89 Compare August 16, 2024 20:46
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-mlqpqmzwwlru branch from 503e3a1 to 34b99eb Compare August 16, 2024 20:46
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from 3f5ec89 to f949a2e Compare August 16, 2024 20:48
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-mlqpqmzwwlru branch from 34b99eb to 0eace54 Compare August 16, 2024 20:48
Base automatically changed from sloane/push-mlqpqmzwwlru to main August 16, 2024 20:49
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch 4 times, most recently from b387430 to bdd1027 Compare August 19, 2024 17:51
@sloanelybutsurely sloanelybutsurely changed the base branch from main to sloane/push-unnvslkwtssp August 19, 2024 17:51
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from bdd1027 to 19dca86 Compare August 19, 2024 19:48
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-unnvslkwtssp branch from 7de8900 to 45f9f98 Compare August 19, 2024 19:48
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from 19dca86 to 207cf38 Compare August 20, 2024 19:24
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-unnvslkwtssp branch from 45f9f98 to 8df9dc9 Compare August 20, 2024 19:24
Base automatically changed from sloane/push-unnvslkwtssp to main August 20, 2024 19:26
Relies on the in-memory Alerts cache when a request for Alerts data has
filters supported by the cache. Uses the existing V3 API client
otherwise.
@sloanelybutsurely sloanelybutsurely force-pushed the sloane/push-lzxxysnqrnoy branch from 207cf38 to e05e823 Compare August 20, 2024 19:27
@sloanelybutsurely sloanelybutsurely requested review from cmaddox5 and a team and removed request for cmaddox5 August 20, 2024 21:09
Copy link
Contributor

@PaulJKim PaulJKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sloanelybutsurely sloanelybutsurely merged commit 6e69fdc into main Aug 21, 2024
11 checks passed
@sloanelybutsurely sloanelybutsurely deleted the sloane/push-lzxxysnqrnoy branch August 21, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants