refactor: remove redundant Sentry-disabling code #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the multiple overlapping mechanisms for enabling and disabling Sentry, hopefully without changing existing behavior. * If a `SENTRY_DSN` environment variable is defined, and the Mix env is `prod`, Sentry is enabled on the backend. * If the above is true _and_ there is not a `disable_sentry` query param in the URL, Sentry is also enabled on the frontend. There do not appear to be any screens actively using `disable_sentry` at the time of writing, but we'll leave this feature alone for now.
sloanelybutsurely
approved these changes
Aug 16, 2024
cmaddox5
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Wow. We really went for the overkill method with this. I think you're right about no screen using disable_sentry. That was originally put in place because one of our screen types (GDS E-Ink maybe?) would crash if it tried to initialize it. Might be a good idea to leave in just in case we get another screen with a similar issue.
|
Here is the original context on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the multiple overlapping mechanisms for enabling and disabling Sentry, hopefully without changing existing behavior.
SENTRY_DSNenvironment variable is defined, and the Mix env isprod, Sentry is enabled on the backend.disable_sentryquery param in the URL, Sentry is also enabled on the frontend.There do not appear to be any screens actively using
disable_sentryat the time of writing, but we'll leave this feature alone for now.