fix: Filter out predictions w/ arrival_time but no departure_time. #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sloanelybutsurely
approved these changes
Sep 18, 2024
digitalcora
reviewed
Sep 20, 2024
| @@ -58,6 +59,12 @@ defmodule Screens.V2.Departure.Builder do | |||
|
|
|||
| defp vehicle_already_departed?(_), do: false | |||
|
|
|||
| defp prediction_has_no_departure_time?(%Schedule{}), do: false | |||
There was a problem hiding this comment.
We should also do this for scheduled departures, I think (filtering them out if they have no departure time). We don't want to display an "arrival-only" stop that won't be accepting passengers, even if it's not a live prediction.
|
Turns out that we actually do already have this implemented for both predictions and schedules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional filtering to predictions returned from the API. When a prediction has an
arrival_timebut nodeparture_time, it is an API best practice to filter it out.