-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Elevator evergreen content #2318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌲
elevator_closure_instances_fn.(config) | ||
Enum.concat([ | ||
header_instance(config, now), | ||
footer_instance(config), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused as to how this works. header_
and footer_instance
return a single widget struct, which is not an enumerable, and Enum.concat/1
expects an enum of enums. Doing the equivalent of this call in IEx results in an error:
iex(1)> Enum.concat([:a, :b, [:c, :d], [:e, :f]])
** (Protocol.UndefinedError) protocol Enumerable not implemented for :a of type Atom
(elixir 1.15.7) lib/enum.ex:1: Enumerable.impl_for!/1
(elixir 1.15.7) lib/enum.ex:166: Enumerable.reduce/3
(elixir 1.15.7) lib/enum.ex:4387: anonymous fn/3 in Enum.concat_enum/1
(elixir 1.15.7) lib/enum.ex:2510: Enum."-concat_enum/1-lists^foldl/2-1-"/3
(elixir 1.15.7) lib/enum.ex:2510: Enum.concat_enum/1
iex:1: (file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🫥
Adds evergreen content support on elevator screens. Assuming
Screens.Util.Assets.s3_asset_url/1
points at thescreens-dev-green
bucket, you can use the following config to test: