fix: Missed Stops should not display until detour finished (#2520)

mbta · Mar 26, 2024 · fb83a22 · fb83a22
1 parent 2ccecdd
commit fb83a22
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/assets/src/hooks/useDetour.ts b/assets/src/hooks/useDetour.ts
@@ -133,9 +133,11 @@ export const useDetour = ({ routePatternId, shape }: OriginalRoute) => {
     setState(DetourState.Edit)
   }
 
-  const missedStops = finishedDetour?.missedStops || []
+  const missedStops = finishedDetour?.missedStops || undefined
 
-  const missedStopIds = new Set(missedStops.map((stop) => stop.id))
+  const missedStopIds = missedStops
+    ? new Set(missedStops.map((stop) => stop.id))
+    : new Set()
   const stops = (shape.stops || []).map((stop) => ({
     ...stop,
     missed: missedStopIds.has(stop.id),

diff --git a/assets/tests/hooks/useDetour.test.ts b/assets/tests/hooks/useDetour.test.ts
@@ -388,7 +388,7 @@ describe("useDetour", () => {
     act(() => result.current.undo?.())
 
     await waitFor(() => {
-      expect(result.current.missedStops).toHaveLength(0)
+      expect(result.current.missedStops).toBeUndefined()
     })
   })