feat: Base work to get detours in route ladder dropdown #2915
+129
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2025
bfauble
reviewed
Jan 6, 2025
| .dropdown-menu { | ||
| border-radius: 0.25rem; | ||
| max-width: 20.5rem; | ||
| min-width: 20.5rem; |
There was a problem hiding this comment.
not a huge issue but when only one ladder is shown with a detour, the dropdown is cut off on the right side based on the width of the c-route-ladders div
There was a problem hiding this comment.
Oh totally! Yeah that'd be good to fix. I'll either do that separately, or make a bug ticket since this is an issue in prod already, separate from this PR
hannahpurcell
force-pushed
the
hp/hook-for-loading-single-detour
branch
from
31b72ae to
01404bb
Compare
hannahpurcell
force-pushed
the
hp/detours-in-route-ladder-dropdown
branch
from
a7f7878 to
8cf9e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Ticket: https://app.asana.com/0/1205385723132845/1208748637161894
To be covered in a future PR:
Needed: