Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added USD values #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

shubhiscoding
Copy link

Used this conigecko API mentioned in the issue #7
https://api.geckoterminal.com/api/v2/simple/networks/solana/token_price/${address}
Note: the usd values are the values based on the current price not the price based on the date of trade
Screenshot from 2024-11-04 00-08-36

Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jupalyse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 6:50pm

@mcintyre94
Copy link
Owner

Hey, thanks for taking a look at this! I think the value here is definitely from a historic price perspective, that's the value that is interesting from a tax POV. It is also interesting to see how these trades worked out in dollar terms over time, but at least for now that's a different product from Jupalyse.

If you'd be interested in seeing how to get historical prices then that'd be awesome, but no pressure! Let me know if you'd lik to keep working on this :)

@shubhiscoding
Copy link
Author

Hey, thanks for taking a look at this! I think the value here is definitely from a historic price perspective, that's the value that is interesting from a tax POV. It is also interesting to see how these trades worked out in dollar terms over time, but at least for now that's a different product from Jupalyse.

If you'd be interested in seeing how to get historical prices then that'd be awesome, but no pressure! Let me know if you'd lik to keep working on this :)

Yeah that makes sense! I'll try to get historic price instead!

@shubhiscoding
Copy link
Author

Hey @mcintyre94! turns out geckoterminal api has no endpoint for historic price data, I'm looking for any other free options, If you find something do tell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants