Add workaround for #218

mdaines · Oct 25, 2023 · 89bbb47 · 89bbb47
1 parent 68b1126
commit 89bbb47
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/packages/viz/src/module/viz.c b/packages/viz/src/module/viz.c
@@ -73,6 +73,12 @@ Agraph_t *viz_read_one_graph(char *string) {
   Agraph_t *graph = NULL;
   Agraph_t *other_graph = NULL;
 
+  // Set the global default node label if not already set.
+
+  if (!agattr(NULL, AGNODE, "label", 0)) {
+    agattr(NULL, AGNODE, "label", "\\N");
+  }
+
   // Reset errors
 
   agseterrf(viz_errorf);

diff --git a/packages/viz/test/render.test.mjs b/packages/viz/test/render.test.mjs
@@ -290,7 +290,7 @@ stop
         status: "success",
         output: "graph {\n\tgraph [_background=123,\n\t\tbb=\"0,0,0,0\"\n\t];\n\tnode [label=\"\\N\"];\n}\n",
         errors: [
-          { level: "warning", message: "Could not parse \"_background\" attribute in graph %1" },
+          { level: "warning", message: "Could not parse \"_background\" attribute in graph %3" },
           { level: "warning", message: "  \"123\"" }
         ]
       });
@@ -308,5 +308,26 @@ stop
         ]
       });
     });
+
+    it("the graph is read with the default node label set", function() {
+      const result = viz.render("graph { a; b[label=test] }");
+
+      assert.deepStrictEqual(result, {
+        status: "success",
+        output: `graph {
+	graph [bb="0,0,126,36"];
+	node [label="\\N"];
+	a	[height=0.5,
+		pos="27,18",
+		width=0.75];
+	b	[height=0.5,
+		label=test,
+		pos="99,18",
+		width=0.75];
+}
+`,
+        errors: []
+      });
+    });
   });
 });