fix(Backend): 🐛 use multipart for imgur api to send image other than …

…webp

backend/Cargo.toml

@@ -60,7 +60,7 @@ features = ["serde"]
 [dependencies.reqwest]
 version = "0.11.22"
 default-features = false
-features = ["rustls-tls", "json"]
+features = ["rustls-tls", "json","multipart"]
 
 [dependencies.k256]
 version = "0.13.2"

backend/src/controller/duplicate.rs

@@ -16,9 +16,9 @@ struct DupKey {
 }
 
 /// Request Duplication
-/// 
+///
 /// It cache request result with fat pointer and provide safe interface to access data
-/// 
+///
 /// Note that for effeciency, it uses Clock-Pro cache algorithm, expect occasional missing,
 /// shouldn't be rely on in unstable connection
 pub struct DupController {

backend/src/controller/imgur.rs

@@ -1,24 +1,26 @@
 use std::collections::HashMap;
 
-use reqwest::Client;
+use reqwest::{multipart, Client};
 use serde::Serialize;
 use tracing::instrument;
 
-use crate::init::config;
+use crate::{init::config, report_internal};
 
 #[derive(Debug, thiserror::Error)]
 pub enum Error {
-    #[error("reqwest error")]
+    #[error("reqwest error `{0}`")]
     Reqwest(#[from] reqwest::Error),
     #[error("old API version was used")]
     OldApi,
+    #[error("Invaild image")]
+    InvaildImage,
 }
 
 impl From<Error> for tonic::Status {
     fn from(value: Error) -> Self {
         match value {
-            Error::Reqwest(x) => tonic::Status::internal(format!("reqwest error: {}", x)),
-            Error::OldApi => tonic::Status::internal("old API version was used"),
+            Error::InvaildImage => tonic::Status::failed_precondition("Invaild image"),
+            _ => report_internal!(error, value),
         }
     }
 }
@@ -51,16 +53,25 @@ impl ImgurController {
     /// upload image
     #[instrument(skip_all, level = "debug")]
     pub async fn upload(&self, image: Vec<u8>) -> Result<String, Error> {
+        // check max image size(10MB)
+        if image.len() >= 10 * 1000 * 1000 {
+            return Err(Error::InvaildImage);
+        }
+
+        let part = multipart::Part::bytes(image).file_name("upload.bin");
+        let form = multipart::Form::new().part("image", part);
+
         let res = self
             .client
             .post("https://api.imgur.com/3/image")
-            .body(image)
+            .multipart(form)
             .header(
                 "Authorization",
                 ["Client-ID", &self.config.client_id].concat(),
             )
             .send()
             .await?;
+
         let payload: HashMap<String, String> = res.json().await?;
 
         let link = payload.get("link").cloned().ok_or(Error::OldApi)?;

backend/src/controller/metrics.rs

@@ -26,9 +26,9 @@ macro_rules! impl_metrics {
 }
 
 /// collection of statful metrics
-/// 
+///
 /// because metrics(opentelemetry) sdk is not yet GA,
-/// stateful metrics is necessary in state of art. 
+/// stateful metrics is necessary in state of art.
 pub struct MetricsController {
     user: UpDownCounter<i64>,
     submit: UpDownCounter<i64>,

backend/src/controller/mod.rs

@@ -1,5 +1,5 @@
 //! collection of controller
-//! 
+//!
 //! controller are stateful, independent conponment and should
 //! include intergated test
 

backend/src/macro_tool.rs

@@ -5,6 +5,10 @@ macro_rules! report_internal {
         tracing::$level!($pattern);
         tonic::Status::internal($pattern.to_string())
     }};
+    ($level:ident,$pattern:expr) => {{
+        tracing::$level!("{}", $pattern);
+        tonic::Status::internal($pattern.to_string())
+    }};
     ($level:ident,$pattern:literal, $error:expr) => {{
         tracing::$level!($pattern, $error);
         tonic::Status::internal($error.to_string())
@@ -18,6 +22,10 @@ macro_rules! report_internal {
         tracing::$level!($pattern);
         tonic::Status::unknown("unknown error")
     }};
+    ($level:ident,$pattern:expr) => {{
+        tracing::$level!("{}", $pattern);
+        tonic::Status::unknown("unknown error")
+    }};
     ($level:ident,$pattern:literal, $error:expr) => {{
         tracing::$level!($pattern, $error);
         tonic::Status::unknown("unknown error")

judger/src/langs/mod.rs

@@ -26,15 +26,15 @@ pub enum InitError {
 pub enum Error {
     #[error("Language not found")]
     LangNotFound,
-    #[error("Internal Error: `{0}`")]
+    #[error("`{0}`")]
     Sandbox(#[from] sandbox::Error),
 }
 
 impl From<Error> for tonic::Status {
     fn from(value: Error) -> Self {
         match value {
             Error::LangNotFound => tonic::Status::failed_precondition("lang not found"),
-            Error::Sandbox(x) => tonic::Status::internal(format!("{}", x)),
+            _ => tonic::Status::internal(value.to_string()),
         }
     }
 }