Base URL Fixes #63
Open
Base URL Fixes #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aryaei2000
commented
Nov 21, 2024
aryaei2000
commented
- A few fixes to make sure environment variables containing a service URL are loaded upon container running
- Documented relevant environment variables with examples
- Added discovery service to docker-compose.yml
aryaei2000
added
bug
szschaler
requested changes
Nov 21, 2024
| Before building the platform the ```env.example``` file should be renamed to ```.env``` and the environment variables listed below must be populated with relevant values listed below. | ||
|
|
||
| + **TRUSTED_ORIGINS** comma delimited whitelist of base URLs (with no trailing slash) for CORS aware endpoints | ||
| + **ES_DEPLOY_ADDRESS** base URL + /tools/xtext/editors |
There was a problem hiding this comment.
Would be good to explain why this is needed. Why not, instead, simply have a BASE_URL variable and compute the rest from there?
aryaei2000
requested review from
szschaler
and removed request for
barnettwilliam
szschaler
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.