Merge pull request #200 from mdenet/fix/41-use-only-given-parameters

Fix only provide parameters used by tool functions
mdenet · Mar 21, 2024 · 3eefcaf · 3eefcaf
2 parents 04c62fa + cbd180f
commit 3eefcaf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/platform/src/EducationPlatformApp.js b/platform/src/EducationPlatformApp.js
@@ -491,11 +491,7 @@ class EducationPlatformApp {
 
                     const panelConfig = parameterMap.get(param.name); 
 
-                    if (panelConfig == undefined){
-                        // Set unused parameters in the request to undefined as the epsilon backend function expects them all. 
-                        actionRequestData[param.name] = "undefined";
-
-                    } else {
+                    if (panelConfig != undefined){
                         let parameterData = values.find(val => (val.name === param.name) );
 
                         actionRequestData[param.name] =  parameterData.data;

diff --git a/platform/test/spec/testEducationPlatformAppSpec.js b/platform/test/spec/testEducationPlatformAppSpec.js
@@ -296,9 +296,7 @@ describe("EducationPlatformApp", () => {
             expect(platform.functionRegistry_call).toHaveBeenCalledWith(ACTION_FUNCTION_ID, EXPECTED_PARAM_VALUES);
         })
 
-        it("sends request to a conversion function's url with unused parameters set to undefined", async () => {
-            /* This behaviour was to ensure compatibility with java google cloud function based
-             * Epsilon playground pre Micronaut that required all parameters to be provided. */
+        it("sends requests to a conversion function's url without unused parameters", async () => {
             const PARAM1_TYPE = ACTION_FUNCTION_PARAM1_TYPE;
 
             const parameterMap = new Map (
@@ -323,7 +321,6 @@ describe("EducationPlatformApp", () => {
             // Check the expected results
             const EXPECTED_PARAM_VALUES = {
                 [PARAM1_NAME]: PARAM1_VALUE,
-                [PARAM2_NAME]: "undefined",
                 "language": TOOL_LANGUAGE
             }