Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save contents of generated Xtext editors, too #133

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Save contents of generated Xtext editors, too #133

merged 5 commits into from
Dec 4, 2023

Conversation

szschaler
Copy link
Contributor

Closes #132

@szschaler szschaler self-assigned this Nov 29, 2023
@szschaler szschaler added the bug Something isn't working label Nov 29, 2023
@szschaler szschaler mentioned this pull request Nov 30, 2023
Closed
@szschaler
Copy link
Contributor Author

Actually, this is the wrong way of going about this. We should really add a canSave method to Panel that returns true for those panels for which saving is possible. Panels should then have a save method that can be invokved to do the actual saving, provided some broader context from the Playground.

@szschaler szschaler marked this pull request as draft November 30, 2023 09:06
@szschaler szschaler marked this pull request as ready for review November 30, 2023 10:52
@szschaler
Copy link
Contributor Author

Ready for review @barnettwilliam

barnettwilliam
barnettwilliam approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@barnettwilliam barnettwilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested using mdenet/educationplatform-docker@a1496bf

@barnettwilliam barnettwilliam merged commit 196f667 into main Dec 4, 2023
2 checks passed
@barnettwilliam barnettwilliam deleted the fix/save-xtext-editor-contents branch December 4, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnettwilliam barnettwilliam barnettwilliam approved these changes

Assignees

@szschaler szschaler

Labels
bug Something isn't working
Projects
Education Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saving doesn't work in generated Xtext editors
2 participants
@szschaler @barnettwilliam