Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage editor state when changing contents #148

Merged
merged 5 commits into from
Dec 11, 2023
Merged

Manage editor state when changing contents #148

merged 5 commits into from
Dec 11, 2023

Conversation

szschaler
Copy link
Contributor

@szschaler szschaler commented Dec 8, 2023 •
edited
Loading

This PR introduces code to only save panels whose contents has actually been edited by the user. We do this by using the clean/dirty flag maintained by ACE's UndoManager class.

Closes #146

@szschaler szschaler self-assigned this Dec 8, 2023
@szschaler szschaler added the enhancement New feature or request label Dec 8, 2023
@szschaler szschaler marked this pull request as ready for review December 8, 2023 20:38
barnettwilliam
barnettwilliam approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@barnettwilliam barnettwilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good and prevents empty commits. It would be be nice to have visual feedback e.g. disable the save button and prevent undoing back to a blank panel but will raise separate issues for these.

@barnettwilliam barnettwilliam merged commit a547712 into main Dec 11, 2023
2 checks passed
@barnettwilliam barnettwilliam deleted the feature/only-save-dirty-panels branch December 11, 2023 11:28
This was referenced Dec 11, 2023
Open
Open
barnettwilliam added a commit to mdenet/educationplatform-docker that referenced this pull request Dec 15, 2023
@barnettwilliam
Updated submodule to include features mdenet/educationplatform#151 co…
59bf696 
…mposite panels and mdenet/educationplatform#148 only save modified panels.
@barnettwilliam barnettwilliam mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnettwilliam barnettwilliam barnettwilliam approved these changes

Assignees

@szschaler szschaler

Labels
enhancement New feature or request
Projects
Education Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid empty commits when saving
2 participants
@szschaler @barnettwilliam