Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tool config schemas #160

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Fix tool config schemas #160

merged 2 commits into from
Jan 10, 2024

Conversation

szschaler
Copy link
Contributor

@szschaler szschaler commented Jan 10, 2024

This PR fixes several issues in the tool configuration schemas to ensure these are correctly validated.

Panel definitions are expected to be introduced by the `panelDefs` key.
@szschaler szschaler changed the title Fix typo in tool config schema Fix typo in tool config schemas Jan 10, 2024
@szschaler szschaler self-assigned this Jan 10, 2024
Extend `panelclass` enum to include all supported types of panels and allow multiple buttons for a panel definition.
@szschaler szschaler changed the title Fix typo in tool config schemas Fix tool config schemas Jan 10, 2024
@szschaler szschaler added the bug Something isn't working label Jan 10, 2024
@szschaler szschaler marked this pull request as ready for review January 10, 2024 15:56
Copy link
Collaborator

@barnettwilliam barnettwilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szschaler szschaler merged commit 3636944 into main Jan 10, 2024
2 checks passed
@szschaler szschaler deleted the fix/fix-tool-schemas branch January 10, 2024 16:23
barnettwilliam added a commit to mdenet/educationplatform-docker that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants