Add support for URL rewriting in tool specifications #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A minor additional fix to avoid accumulating `/`-es over time
barnettwilliam
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
LGTM. Testing this higlighted an issue with the Xtext tool service endpoint structure but raised as - mdenet/platformtools#37
barnettwilliam
added a commit
to mdenet/educationplatform-docker
that referenced
this pull request
Jan 18, 2024
…l parallel build logs combined and mdenet/educationplatform#163 hiding of generated activities. Features mdenet/platformtools#155 resource management of editor instances and mdenet/educationplatform#162 tool base url rewriting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for tool specifications to use
{{BASE-URL}}to refer to the URL from which the tool is deployed (strictly, the URL where the tool specification is hosted, minus the file name of the tool specification and any trailing/). This will automatically be rewritten when the tool specification is loaded, so that tool specifications can be written independently of location of deployment.