Fix hiding of generated activities #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnettwilliam
added a commit
to mdenet/educationplatform-docker
that referenced
this pull request
Jan 18, 2024
…l parallel build logs combined and mdenet/educationplatform#163 hiding of generated activities. Features mdenet/platformtools#155 resource management of editor instances and mdenet/educationplatform#162 tool base url rewriting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced by #161. Because tools with URL-rewriting in the tool URL may not be loaded unless they have been generated, any panels provided by them can also not be loaded unless the tool has been generated. As a result, checking if a panel is a generated panel cannot rely on the panel definition in these cases. Before this fix, activities with such panels would be shown in the activities menu regardless of whether generation has taken place.
To fix this, we assume that all panels with undefined panel definitions are generated and hide the corresponding activities in the menu. This also has the nice side effect that only activities with fully defined panels are visible in the menu.