Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing panel buttons #171

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Fix for missing panel buttons #171

merged 3 commits into from
Feb 5, 2024

Conversation

barnettwilliam
Copy link
Collaborator

Fix for missing panel buttons. Panel definitions are required to resolve any button references given in an activity config file. Button references are identified by their type that is string rather than object for Buttons.

…lve any button references given in an activity config file. Button references are identified by their type that is string rather than object for Buttons.
Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to clean up the schema at the same time and to revert to using .ref so that there is a clean and consistent structure to the schema.

platform/src/Playground.js Outdated Show resolved Hide resolved
@szschaler szschaler added the bug Something isn't working label Feb 1, 2024
Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I note this still doesn't update the JSON schema.

@barnettwilliam
Copy link
Collaborator Author

Updated the schema in 4e41960

Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barnettwilliam barnettwilliam merged commit 4a4ded4 into main Feb 5, 2024
2 checks passed
@barnettwilliam barnettwilliam deleted the fix/missing-buttons branch February 5, 2024 10:12
barnettwilliam added a commit to mdenet/educationplatform-docker that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants