-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for missing panel buttons #171
Conversation
…lve any button references given in an activity config file. Button references are identified by their type that is string rather than object for Buttons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to clean up the schema at the same time and to revert to using .ref
so that there is a clean and consistent structure to the schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I note this still doesn't update the JSON schema.
Updated the schema in 4e41960 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…latform#172 schema validation missing file, mdenet/educationplatform#171 missing panel buttons, and mdenet/educationplatform#170 file encodings on save.
Fix for missing panel buttons. Panel definitions are required to resolve any button references given in an activity config file. Button references are identified by their type that is string rather than object for Buttons.