Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report all errors on playground start up #175

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

szschaler
Copy link
Contributor

This PR adds code to report all errors on playground startup.

Previous code only reported configuration errors and platform errors, using a specific format, but did not provide a catch-all section reporting any other errors that might occur. This now adds this catch-all block, which will report, for example, parsing errors and errors opening the activitiy file (which closes #128).

@szschaler szschaler self-assigned this Feb 9, 2024
@szschaler szschaler added the bug Something isn't working label Feb 9, 2024
Copy link
Collaborator

@barnettwilliam barnettwilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szschaler szschaler merged commit e3c9a11 into main Feb 9, 2024
2 checks passed
@szschaler szschaler deleted the fix/report-all-errors branch February 9, 2024 11:27
barnettwilliam added a commit to mdenet/educationplatform-docker that referenced this pull request Feb 18, 2024
…token server use ref when loading files, mdenet/educationplatform#178 token server correctly report activity access issues, mdenet/educationplatform#176 resolve activity buttons without tool buttons, mdenet/educationplatform#175 report all errors on startup, mdenet/platformtools#59 added endpoint documentation, and mdenet/platformtools#57 xmi support for epsilon editor config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

If activity file cannot be found, no error message is shown to user
2 participants