Correctly report activity access issues #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barnettwilliam
added a commit
to mdenet/educationplatform-docker
that referenced
this pull request
Feb 18, 2024
…token server use ref when loading files, mdenet/educationplatform#178 token server correctly report activity access issues, mdenet/educationplatform#176 resolve activity buttons without tool buttons, mdenet/educationplatform#175 report all errors on startup, mdenet/platformtools#59 added endpoint documentation, and mdenet/platformtools#57 xmi support for epsilon editor config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem whereby accessing a non-existing activities.json or a file where the permissions were missing would not lead to an error being reported to the user but would quietly crash the token server and the platform.
In the PR, the token server correctly reports the issue and the platform correctly raises an error to the user rather than trying to process the activity specification.