-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled linting #180
Merged
Merged
Enabled linting #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt on errors as the created report file and annotation indicates the errors.
szschaler
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but there are a few places where you seem to have changed behaviour as part of the linting cleanup and I don't understand why you're using TS linting for the token server without any actual typescript code.
…text editor panel init.
This was referenced Feb 22, 2024
szschaler
approved these changes
Feb 22, 2024
barnettwilliam
added a commit
to mdenet/educationplatform-docker
that referenced
this pull request
Feb 23, 2024
…nable lint and mdenet/platformtools#62 line comments toggle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled linting for the education platform code. This is automatically run locally by vscode and the linter is configure to run as part of GitHub action on pushing to a repository. A separate lint report is created similar to the unit test report.
Part of #174