Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled linting #180

Merged
merged 21 commits into from
Feb 22, 2024
Merged

Enabled linting #180

merged 21 commits into from
Feb 22, 2024

Conversation

barnettwilliam
Copy link
Collaborator

@barnettwilliam barnettwilliam commented Feb 21, 2024

Enabled linting for the education platform code. This is automatically run locally by vscode and the linter is configure to run as part of GitHub action on pushing to a repository. A separate lint report is created similar to the unit test report.

Part of #174

@barnettwilliam barnettwilliam mentioned this pull request Feb 8, 2024
5 tasks
Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but there are a few places where you seem to have changed behaviour as part of the linting cleanup and I don't understand why you're using TS linting for the token server without any actual typescript code.

platform/src/ConsolePanel.js Outdated Show resolved Hide resolved
platform/src/Playground.js Outdated Show resolved Hide resolved
platform/src/XtextEditorPanel.js Outdated Show resolved Hide resolved
tokenserver/.eslintrc.js Outdated Show resolved Hide resolved
@barnettwilliam barnettwilliam merged commit d5bc843 into main Feb 22, 2024
3 checks passed
@barnettwilliam barnettwilliam deleted the feature/test-lint branch February 22, 2024 11:27
barnettwilliam added a commit to mdenet/educationplatform-docker that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants