Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test code coverage #185

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Unit test code coverage #185

merged 6 commits into from
Feb 23, 2024

Conversation

barnettwilliam
Copy link
Collaborator

Adds code coverage and reporting of unit tests.

@barnettwilliam
Copy link
Collaborator Author

@szschaler as demo'd in this mornings meeting code coverage is reported in the summary github ci worflow e.g. https://github.com/mdenet/educationplatform/actions/runs/8013383834

There wasn't a huge selection of GiHub actions for reporting code coverage nicely that worked, so went with adding markdown to the workflow action summary using action - https://github.com/danielpalme/ReportGenerator.

Do we want to improve this report e.g. publishing a detailed html report with history as a webpage or do you think the simple output is sufficient?

Another option that offers the most comprehensive and visually appealing report is https://about.codecov.io/ that provide a GitHub action, however, it is an external service so it sends the results to them. It is free for opensource projects, not sure if that applies to us.

@szschaler
Copy link
Contributor

I think that simple output is enough for now.

I notice the following annotation:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Is this something we can fix?

@barnettwilliam
Copy link
Collaborator Author

Yes updating the actions/checkout, actions/setup-dotnet in my test repo fixes this so I'll update here.

@barnettwilliam barnettwilliam marked this pull request as ready for review February 23, 2024 14:16
Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@barnettwilliam barnettwilliam merged commit bc47caf into main Feb 23, 2024
3 checks passed
@barnettwilliam barnettwilliam deleted the feature/test-code-coverage branch February 23, 2024 14:39
@barnettwilliam barnettwilliam mentioned this pull request Feb 29, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants