Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the login box by default and only show for private repo #95

Merged

Conversation

barnettwilliam
Copy link
Collaborator

Hide the login box by default and only show it when a private repo is given. This prevents the login box's brief display when loading a private repo mdenet/educationplatform-docker#2.

Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally OK, though I have two small questions.

platform/src/Playground.js Outdated Show resolved Hide resolved
platform/src/Playground.js Show resolved Hide resolved
@barnettwilliam barnettwilliam merged commit b0193a5 into main Nov 1, 2023
2 checks passed
@barnettwilliam barnettwilliam deleted the 2-first-time-user-issues-github-login-is-briefly-shown branch November 1, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First-time user issues: Github login is briefly shown, error in OCL example
2 participants