Skip to content

Corrected typo suggestion from code review #242

Corrected typo suggestion from code review

Corrected typo suggestion from code review #242

GitHub Actions / Unit Test Results - mac succeeded Mar 14, 2024 in 0s

93 passed, 0 failed and 1 skipped

Tests passed successfully

✅ platform/reports/TESTS-Safari_17.3.1_(Mac_OS_10.15.7).xml

94 tests were completed in 2s with 93 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
Safari 17.3.1 (Mac OS 10.15.7) 93✅ 1⚪ 2s

✅ Safari 17.3.1 (Mac OS 10.15.7)

Safari_17_3_1_(Mac_OS_10_15_7).ToolManager panel definitions
  ✅ ToolManager panel definitions returns the correct object for an existing panel definition id
  ✅ ToolManager panel definitions returns null for a panel definition id that does not exist
Safari_17_3_1_(Mac_OS_10_15_7).ToolManager tool grammar imports
  ✅ ToolManager tool grammar imports correctly loads the ace grammar module for a defined tool
  ✅ ToolManager tool grammar imports correctly loads the URL of the ace grammar for a defined tool
Safari_17_3_1_(Mac_OS_10_15_7).ToolManager constructor
  ✅ ToolManager constructor can be created
Safari_17_3_1_(Mac_OS_10_15_7).ToolManager initialisation
  ✅ ToolManager initialisation sets tools URLs correctly
  ✅ ToolManager initialisation fetches the tool configuration from the remote given by its URL
  ✅ ToolManager initialisation parses and stores the tool configuration
Safari_17_3_1_(Mac_OS_10_15_7).Utility
  ✅ Utility arrayEquals - arrays with matching values are the same
  ✅ Utility arrayEquals - when allow any is not enabled, arrays with any wildcard do not match the corresponding element
  ✅ Utility arrayEquals - arrays with an any wildcard always match the corresponding element
  ✅ Utility parseConfigFile - a json file is parsed to an object
  ✅ Utility arrayEquals - arrays with a wildcard and non matchng other element are not the same
  ✅ Utility parseConfigFile - a json file parsed as yaml to an object
  ✅ Utility parseConfigFile - an unknown file type returns null
  ✅ Utility parseConfigFile - a yaml file is parsed to an object
  ✅ Utility parseConfigFile - an invald yaml file returns an error
  ✅ Utility parseConfigFile - an invald json file returns an error
  ✅ Utility arrayEquals - arrays with the same values in differing order are not the same
Safari_17_3_1_(Mac_OS_10_15_7).ActivityValidator
  ✅ ActivityValidator checkLayoutPanelIdsExist - layout panel ids no error
  ✅ ActivityValidator checkLayoutPanelIdsExist - layout panel ids missing panel
Safari_17_3_1_(Mac_OS_10_15_7).ToolConfigValidator constructor
  ✅ ToolConfigValidator constructor can be created
Safari_17_3_1_(Mac_OS_10_15_7).ToolConfigValidator validate tool configuration
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no parameters key
  ✅ ToolConfigValidator validate tool configuration returns an error if a parameter in the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no returnType key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if a parameter in the config has no type key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no id key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no path key
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no panelclass key
  ✅ ToolConfigValidator validate tool configuration returns an error if a button in the config has no id key
  ✅ ToolConfigValidator validate tool configuration returns an error if the config has no id key
  ✅ ToolConfigValidator validate tool configuration returns an error if a button in the config has no id key
  ✅ ToolConfigValidator validate tool configuration reports no errors for a valid config
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no id key
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no icon key
  ✅ ToolConfigValidator validate tool configuration returns an error if the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if the config has no functions key
Safari_17_3_1_(Mac_OS_10_15_7).FunctionRegistry
  ✅ FunctionRegistry a single registered function using wildcards can be found
  ✅ FunctionRegistry a registered function using wildcards can be found
  ✅ FunctionRegistry a registered function can be looked up
Safari_17_3_1_(Mac_OS_10_15_7).FileHandler
  ✅ FileHandler getPrivateFileUpdateParams - returns null for an unknown file url
  ✅ FileHandler getPrivateFileRequestUrl - returns null for an unknown file url
  ✅ FileHandler getPrivateFileRequestUrl - returns a token server request url from a raw github file url
  ✅ FileHandler githubRawUrlTorequestUrl - returns a token server request url from a raw github file url
  ✅ FileHandler githubRawUrlToStoreRequest - returns an object with a token server request url member from a raw github file url
  ✅ FileHandler githubRawUrlToStoreRequest - returns an object with a token server requestParams member from a raw github file url
  ✅ FileHandler getPrivateFileUpdateParams - returns
Safari_17_3_1_(Mac_OS_10_15_7).Button
  ✅ Button getView - outputs a DOM representation for customButtons properties
  ✅ Button has an icon set by a config object
  ✅ Button has an id set by a config object
  ✅ Button has an hint set by a config object
  ✅ Button createButtons - creates multiple buttons from  an array of button objects
  ✅ Button can be created
Safari_17_3_1_(Mac_OS_10_15_7).ActivityManager constructor
  ✅ ActivityManager constructor can be created
  ✅ ActivityManager constructor initialises the accessPanelDef property using param panelDefAccessor
  ✅ ActivityManager constructor uses the query string to set the activitiesUrl property
  ✅ ActivityManager constructor initialises the configValidator property
  ✅ ActivityManager constructor initialises the fileHandler property  using param fileHandler
  ✅ ActivityManager constructor sets the activityId property if the current activity is provided in the url query string
Safari_17_3_1_(Mac_OS_10_15_7).ActivityManager activity initialisation
  ✅ ActivityManager activity initialisation the activities actions property panel references have been resolved
  ✅ ActivityManager activity initialisation the panel definitions the current activity references are unresolved
  ✅ ActivityManager activity initialisation current activity activityId property is set to the activity id
  ✅ ActivityManager activity initialisation the activities property has a key matching the activity id
  ✅ ActivityManager activity initialisation resolves references for a valid activity by  calling resolveActionReferences with activity id
  ✅ ActivityManager activity initialisation no config errors empty configErrors propererty
  ✅ ActivityManager activity initialisation the activities property is an object that has required keys
  ✅ ActivityManager activity initialisation causes the activity file to be fetched from its URL using the fileHandler
  ✅ ActivityManager activity initialisation an activities property's value is an object
Safari_17_3_1_(Mac_OS_10_15_7).ActivityManager getting current activity
  ✅ ActivityManager getting current activity the panel definitions for the current activity references are resolved
  ✅ ActivityManager getting current activity the activity files are fetched using FileHandler
Safari_17_3_1_(Mac_OS_10_15_7).ActivityConfigValidator constructor
  ✅ ActivityConfigValidator constructor can be created
Safari_17_3_1_(Mac_OS_10_15_7).ActivityConfigValidator validate activity configuration
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no layout key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no tools key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel button in config has no icon key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel in config has no ref key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no actions key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel button in config has no id key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no parameters key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel in config has no name key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no output key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no source key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel button ref in config has no ref key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no sourceButton key
  ✅ ActivityConfigValidator validate activity configuration reports no errors for a valid config
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel in config has no id key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no panels key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no title key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no id key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config layout has no area key
Safari_17_3_1_(Mac_OS_10_15_7).ActionFunction
  ✅ ActionFunction instance of a parameter name returns the the corresponding id
  ✅ ActionFunction object creation - id
  ⚪ ActionFunction instance of a the return type returns the the corresponding id