Skip to content

Merge pull request #190 from mdenet/fix/unittests-activityvalidator #264

Merge pull request #190 from mdenet/fix/unittests-activityvalidator

Merge pull request #190 from mdenet/fix/unittests-activityvalidator #264

GitHub Actions / Unit Test Results - mac succeeded Mar 21, 2024 in 1s

136 passed, 0 failed and 1 skipped

Tests passed successfully

✅ platform/reports/TESTS-Safari_17.3.1_(Mac_OS_10.15.7).xml

137 tests were completed in 2s with 136 passed, 0 failed and 1 skipped.

Test suite Passed Failed Skipped Time
Safari 17.3.1 (Mac OS 10.15.7) 136✅ 1⚪ 2s

✅ Safari 17.3.1 (Mac OS 10.15.7)

Safari_17_3_1_(Mac_OS_10_15_7).ToolConfigValidator validate tool configuration
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no id key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if the config has no functions key
  ✅ ToolConfigValidator validate tool configuration returns an error if the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if a parameter in the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no icon key
  ✅ ToolConfigValidator validate tool configuration returns an error if the config has no id key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no parameters key
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no panelclass key
  ✅ ToolConfigValidator validate tool configuration reports no errors for a valid config
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no id key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no path key
  ✅ ToolConfigValidator validate tool configuration returns an error if a button in the config has no id key
  ✅ ToolConfigValidator validate tool configuration returns an error if a panel definition in the config has no name key
  ✅ ToolConfigValidator validate tool configuration returns an error if a parameter in the config has no type key
  ✅ ToolConfigValidator validate tool configuration returns an error if a function in the config has no returnType key
  ✅ ToolConfigValidator validate tool configuration returns an error if a button in the config has no id key
Safari_17_3_1_(Mac_OS_10_15_7).ToolConfigValidator constructor
  ✅ ToolConfigValidator constructor can be created
Safari_17_3_1_(Mac_OS_10_15_7).ToolManager panel definitions
  ✅ ToolManager panel definitions returns null for a panel definition id that does not exist
  ✅ ToolManager panel definitions returns the correct object for an existing panel definition id
Safari_17_3_1_(Mac_OS_10_15_7).ToolManager tool grammar imports
  ✅ ToolManager tool grammar imports correctly loads the URL of the ace grammar for a defined tool
  ✅ ToolManager tool grammar imports correctly loads the ace grammar module for a defined tool
Safari_17_3_1_(Mac_OS_10_15_7).ToolManager constructor
  ✅ ToolManager constructor can be created
Safari_17_3_1_(Mac_OS_10_15_7).ToolManager initialisation
  ✅ ToolManager initialisation fetches the tool configuration from the remote given by its URL
  ✅ ToolManager initialisation parses and stores the tool configuration
  ✅ ToolManager initialisation sets tools URLs correctly
Safari_17_3_1_(Mac_OS_10_15_7).ActivityConfigValidator validate activity configuration
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel button in config has no id key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no parameters key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no sourceButton key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel in config has no ref key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel in config has no name key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config layout has no area key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no id key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no panels key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no title key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel button in config has no icon key
  ✅ ActivityConfigValidator validate activity configuration reports no errors for a valid config
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no source key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no actions key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a config action has no output key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no tools key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel button ref in config has no ref key
  ✅ ActivityConfigValidator validate activity configuration returns an error if the config has no layout key
  ✅ ActivityConfigValidator validate activity configuration returns an error if a panel in config has no id key
Safari_17_3_1_(Mac_OS_10_15_7).ActivityConfigValidator constructor
  ✅ ActivityConfigValidator constructor can be created
Safari_17_3_1_(Mac_OS_10_15_7).ActionFunction
  ⚪ ActionFunction instance of a the return type returns the the corresponding id
  ✅ ActionFunction object creation - id
  ✅ ActionFunction instance of a parameter name returns the the corresponding id
Safari_17_3_1_(Mac_OS_10_15_7).FunctionRegistry
  ✅ FunctionRegistry a single registered function using wildcards can be found
  ✅ FunctionRegistry a registered function using wildcards can be found
  ✅ FunctionRegistry a registered function can be looked up
Safari_17_3_1_(Mac_OS_10_15_7).FileHandler
  ✅ FileHandler githubRawUrlTorequestUrl - returns a token server request url from a raw github file url
  ✅ FileHandler githubRawUrlToStoreRequest - returns an object with a token server request url member from a raw github file url
  ✅ FileHandler getPrivateFileRequestUrl - returns a token server request url from a raw github file url
  ✅ FileHandler githubRawUrlToStoreRequest - returns an object with a token server requestParams member from a raw github file url
  ✅ FileHandler getPrivateFileRequestUrl - returns null for an unknown file url
  ✅ FileHandler getPrivateFileUpdateParams - returns
  ✅ FileHandler getPrivateFileUpdateParams - returns null for an unknown file url
Safari_17_3_1_(Mac_OS_10_15_7).ActivityManager constructor
  ✅ ActivityManager constructor initialises the accessPanelDef property using param panelDefAccessor
  ✅ ActivityManager constructor initialises the fileHandler property  using param fileHandler
  ✅ ActivityManager constructor sets the activityId property if the current activity is provided in the url query string
  ✅ ActivityManager constructor initialises the configValidator property
  ✅ ActivityManager constructor uses the query string to set the activitiesUrl property
  ✅ ActivityManager constructor can be created
Safari_17_3_1_(Mac_OS_10_15_7).ActivityManager getting current activity
  ✅ ActivityManager getting current activity the activity files are fetched using FileHandler
  ✅ ActivityManager getting current activity the panel definitions for the current activity references are resolved
Safari_17_3_1_(Mac_OS_10_15_7).ActivityManager activity initialisation
  ✅ ActivityManager activity initialisation resolves references for a valid activity by  calling resolveActionReferences with activity id
  ✅ ActivityManager activity initialisation the panel definitions the current activity references are unresolved
  ✅ ActivityManager activity initialisation the activities actions property panel references have been resolved
  ✅ ActivityManager activity initialisation the activities property has a key matching the activity id
  ✅ ActivityManager activity initialisation causes the activity file to be fetched from its URL using the fileHandler
  ✅ ActivityManager activity initialisation an activities property's value is an object
  ✅ ActivityManager activity initialisation no config errors empty configErrors property
  ✅ ActivityManager activity initialisation the activities property is an object that has required keys
  ✅ ActivityManager activity initialisation current activity activityId property is set to the activity id
Safari_17_3_1_(Mac_OS_10_15_7).ActivityValidator checkActions()
  ✅ ActivityValidator checkActions() returns an error if output panel ids cannot be resolved
  ✅ ActivityValidator checkActions() returns an error if outputConsole panel ids cannot be resolved
  ✅ ActivityValidator checkActions() returns an error if source panel ids cannot be resolved
  ✅ ActivityValidator checkActions() returns no errors if panel ids can be resolved
Safari_17_3_1_(Mac_OS_10_15_7).ActivityValidator checkLayoutPanelIdsExist()
  ✅ ActivityValidator checkLayoutPanelIdsExist() returns no errors if panel ids can be resolved
  ✅ ActivityValidator checkLayoutPanelIdsExist() returns an error if a panel ids cannot be resolved
Safari_17_3_1_(Mac_OS_10_15_7).ActivityValidator checkPanelDefs()
  ✅ ActivityValidator checkPanelDefs() returns an error if a panel definition button renderfunction ref cannot be resolved
  ✅ ActivityValidator checkPanelDefs() returns no errors if panel definitions are valid
  ✅ ActivityValidator checkPanelDefs() returns an error if a panel definition button actionfunction ref cannot be resolved
Safari_17_3_1_(Mac_OS_10_15_7).ActivityValidator checkPanelRefs()
  ✅ ActivityValidator checkPanelRefs() returns an error if a panel definition ref is not resolved
  ✅ ActivityValidator checkPanelRefs() returns no errors if panel definition refs are resolved
Safari_17_3_1_(Mac_OS_10_15_7).ActivityValidator idExists()
  ✅ ActivityValidator idExists() returns true if an id that exists in the items is found where the items are classes
  ✅ ActivityValidator idExists() returns false if an id does not exist in the items
  ✅ ActivityValidator idExists() returns true if an id that exists in the items is found
Safari_17_3_1_(Mac_OS_10_15_7).ActivityValidator validate()
  ✅ ActivityValidator validate() returns errors if invalid activity and tools are given
  ✅ ActivityValidator validate() calls all validation functions
  ✅ ActivityValidator validate() returns no errors if valid activity and tools are given
Safari_17_3_1_(Mac_OS_10_15_7).Button
  ✅ Button createButtons - creates multiple buttons from  an array of button objects
  ✅ Button has an hint set by a config object
  ✅ Button has an icon set by a config object
  ✅ Button can be created
  ✅ Button has an id set by a config object
  ✅ Button getView - outputs a DOM representation for customButtons properties
Safari_17_3_1_(Mac_OS_10_15_7).Utility
  ✅ Utility parseConfigFile - a json file is parsed to an object
  ✅ Utility parseConfigFile - a yaml file is parsed to an object
  ✅ Utility arrayEquals - arrays with matching values are the same
  ✅ Utility parseConfigFile - a json file parsed as yaml to an object
  ✅ Utility arrayEquals - arrays with the same values in differing order are not the same
  ✅ Utility arrayEquals - arrays with an any wildcard always match the corresponding element
  ✅ Utility arrayEquals - when allow any is not enabled, arrays with any wildcard do not match the corresponding element
  ✅ Utility parseConfigFile - an invald json file returns an error
  ✅ Utility arrayEquals - arrays with a wildcard and non matchng other element are not the same
  ✅ Utility parseConfigFile - an unknown file type returns null
  ✅ Utility parseConfigFile - an invald yaml file returns an error
Safari_17_3_1_(Mac_OS_10_15_7).EducationPlatformApp convert()
  ✅ EducationPlatformApp convert() returns null and provides an error notification on a conversion function not being available
  ✅ EducationPlatformApp convert() calls functionRegistry_callConversion on a conversion function being available
  ✅ EducationPlatformApp convert() returns a promise on a conversion function being available
Safari_17_3_1_(Mac_OS_10_15_7).EducationPlatformApp invokeActionFunction()
  ✅ EducationPlatformApp invokeActionFunction() calls functionRegistry_call with the converted parameter values for non-matching types including a metamodel
  ✅ EducationPlatformApp invokeActionFunction() returns the result via a promise
  ✅ EducationPlatformApp invokeActionFunction() sends requests to a conversion function's url without unused parameters
  ✅ EducationPlatformApp invokeActionFunction() calls functionRegistry_call with the given parameter values for matching types
  ✅ EducationPlatformApp invokeActionFunction() calls functionRegistry_call with the converted parameter values for non-matching types
Safari_17_3_1_(Mac_OS_10_15_7).EducationPlatformApp selectConversionFunctionConvertMetamodel()
  ✅ EducationPlatformApp selectConversionFunctionConvertMetamodel() returns null if no conversion is available considering the metamodel
  ✅ EducationPlatformApp selectConversionFunctionConvertMetamodel() returns null if a conversion is not possible without considering the metamodel
  ✅ EducationPlatformApp selectConversionFunctionConvertMetamodel() returns a function id, converts the metamodel, and adds the converted metamodel value to the typeValueMap if a conversion is possible considering the metamodel
  ✅ EducationPlatformApp selectConversionFunctionConvertMetamodel() returns a function id if a conversion is possible without considering the metamodel
Safari_17_3_1_(Mac_OS_10_15_7).EducationPlatformApp convertIncludingMetamodel()
  ✅ EducationPlatformApp convertIncludingMetamodel() calls functionRegistry_callConversion on a conversion function being available
  ✅ EducationPlatformApp convertIncludingMetamodel() returns a promise on a conversion function being available
  ✅ EducationPlatformApp convertIncludingMetamodel() returns null and provides an error notification on a conversion function not being available
Safari_17_3_1_(Mac_OS_10_15_7).EducationPlatformApp functionRegistry_callConversion()
  ✅ EducationPlatformApp functionRegistry_callConversion() returns the converted result via a promise
  ✅ EducationPlatformApp functionRegistry_callConversion() sends a request to the tool service url
Safari_17_3_1_(Mac_OS_10_15_7).EducationPlatformApp functionRegistry_call()
  ✅ EducationPlatformApp functionRegistry_call() sends a request to the tool service url
  ✅ EducationPlatformApp functionRegistry_call() returns the result via promise
Safari_17_3_1_(Mac_OS_10_15_7).EducationPlatformApp notification()
  ✅ EducationPlatformApp notification() displays a message with given title and text
Safari_17_3_1_(Mac_OS_10_15_7).EducationPlatformApp successNotification()
  ✅ EducationPlatformApp successNotification() calls notification with the given text
Safari_17_3_1_(Mac_OS_10_15_7).EducationPlatformApp errorNotification()
  ✅ EducationPlatformApp errorNotification() calls notification with the given text
Safari_17_3_1_(Mac_OS_10_15_7).EducationPlatformApp longNotification()
  ✅ EducationPlatformApp longNotification() calls notification() with the given text
Safari_17_3_1_(Mac_OS_10_15_7).EducationPlatformApp runAction()
  ✅ EducationPlatformApp runAction() populates the language parameter
  ✅ EducationPlatformApp runAction() calls invokeActionFunction with the action functions parameters and their values
  ✅ EducationPlatformApp runAction() calls handleResponseActionFunction with the current action and the invoked function's result promise
  ✅ EducationPlatformApp runAction() provides a notification indicating functions are executing
  ✅ EducationPlatformApp runAction() provides an error notification on unsuccessful function invocation result