Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base URL placeholder added #69

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Base URL placeholder added #69

merged 7 commits into from
Dec 12, 2024

Conversation

aryaei2000
Copy link
Collaborator

Various occurrences of 127.0.0.1 were replaced with {{BASE-URL}} as a placeholder.

@aryaei2000 aryaei2000 added bug Something isn't working enhancement New feature or request labels Sep 10, 2024
@aryaei2000 aryaei2000 self-assigned this Sep 10, 2024
szschaler
szschaler requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I am suggesting some changes:

  • Check the proposed use of {{BASE-URL}} is correct -- I don't think it is
  • Add documentation for the newly introduced arguments

static.conversion/public/conversion_tool.json Show resolved Hide resolved
xtext/Dockerfile Show resolved Hide resolved
xtext/Dockerfile Show resolved Hide resolved
szschaler
szschaler approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@szschaler szschaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Let's add those two comments, then the PR can be merged.

I note this should only be merged when the platform PR has been merged.

xtext/Dockerfile Show resolved Hide resolved
xtext/Dockerfile Show resolved Hide resolved
aryaei2000 and others added 2 commits November 27, 2024 14:48
@aryaei2000 @szschaler
Update xtext/Dockerfile
2ffd55e 
Co-authored-by: Steffen Zschaler <[email protected]>
@aryaei2000 @szschaler
Update xtext/Dockerfile
c316ffd 
Co-authored-by: Steffen Zschaler <[email protected]>
@szschaler
Copy link
Contributor

This should only be merged when the platform PR (mdenet/educationplatform#213) has been merged.

@aryaei2000 aryaei2000 requested a review from szschaler December 10, 2024 11:10
@aryaei2000 aryaei2000 merged commit 64b151e into main Dec 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szschaler szschaler Awaiting requested review from szschaler

Assignees

@aryaei2000 aryaei2000

Labels
bug Something isn't working enhancement New feature or request
Projects
Education Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aryaei2000 @szschaler