Merge pull request #8 from mdiebolt/squashed-additional-metrics

Add additional metrics functionLength, cyclomaticComplexity, letterGrade

README.md

@@ -15,7 +15,26 @@ Generates a report of churn and complexity for `file1.coffee`, `file2.coffee`, a
 ## Contributing
 
 1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+1. Create your feature branch (`git checkout -b my-new-feature`)
+1. Commit your changes (`git commit -am 'Add some feature'`)
+1. Push to the branch (`git push origin my-new-feature`)
+1. Create new Pull Request
+
+## TODO
+
+Stub out fs read file to speed up CLI specs
+
+## Known issues
+
+Method length metric can be incorrect if you have comments at the same level as another function.
+
+```coffee
+fnOne = ->
+  doSomething()
+
+# This is what function two does
+fnTwo = ->
+  doSomethingElse()
+```
+
+In the above example the comment above `fnTwo` will be added to the method length calculation for `fnOne`.

bin/clog

@@ -1,38 +1,7 @@
 #!/usr/bin/env node
 
-var __slice = [].slice
-
-var clog = require("../lib/clog").clog
+var cli = require("../lib/cli")
 var argv = require("minimist")(process.argv.slice(2))
 
-function command() {
-  var commands = []
-  if (arguments.length >= 1)
-    commands = __slice.call(arguments, 0)
-
-  return commands.reduce(function(memo, c) {
-    if (argv[c]) {
-      memo = true
-    }
-    return memo
-  }, false)
-}
-
-var USAGE = "\nUsage: clog path/to/file1.coffee path/to/directory\n\n-h, --help    display this message\n-v, --version display the current version"
-var message = USAGE
-
-if (command("h", "help")) {
-  message = USAGE
-} else if (command("v", "version")) {
-  message = clog.VERSION
-} else if (argv._.length) {
-  if (command("p", "pretty-print")) {
-    printOptions = { indentSpace: 2 }
-  } else {
-    printOptions = {}
-  }
-
-  message = clog.report(argv._, printOptions)
-}
-
-console.log(message)
+console.log(cli(argv))
+process.exit(0)

coffeelint.json

@@ -16,8 +16,8 @@
     }
   },
   "cyclomatic_complexity": {
-    "value": 10,
-    "level": "warn"
+    "value": 7,
+    "level": "error"
   },
   "duplicate_key": {
     "level": "error"
@@ -120,5 +120,10 @@
   },
   "transform_messes_up_line_numbers": {
     "level": "warn"
+  },
+  "no_long_functions": {
+    "module": "coffeelint-no-long-functions",
+    "level": "error",
+    "value": 20
   }
 }