Skip to content

Commit

Permalink
Check UnitTests and version update before release.
Browse files Browse the repository at this point in the history
  • Loading branch information
mdima committed Jun 15, 2024
1 parent e2f7bc6 commit f80b35a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ Based on the original repository: https://github.com/bencorn/traceroute

### Running in Docker
You can use the following image to run Visual Trace Route locally:
michele73/traceroute:1.2.2
michele73/traceroute:1.2.3

Example:
docker run -d -p 8081:80 --name=traceroute --restart=always -v traecroute_logs:/app/logs michele73/traceroute:1.2.2
docker run -d -p 8081:80 --name=traceroute --restart=always -v traecroute_logs:/app/logs michele73/traceroute:1.2.3

The image repository is here: https://hub.docker.com/r/michele73/traceroute

Expand Down
2 changes: 1 addition & 1 deletion TraceRoute/Services/ReverseLookupService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public async Task<string> GetHostName(string ipAddress)
_logger.LogDebug("Lookup bash result: {0}", lookupResult);

var splits = lookupResult.Split(" ", StringSplitOptions.RemoveEmptyEntries).ToList();
if (splits.Count > 0 && !lookupResult.Contains("not found:"))
if (splits.Count > 0 && !lookupResult.Contains("not found:") && !lookupResult.Contains("has no PTR record"))
{
result = splits.Last();
result = result.Replace("\n", "");
Expand Down
4 changes: 2 additions & 2 deletions UnitTests/Services/IpApiClientTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@ public async Task GetKnownIP()
Assert.AreEqual("Milan", result.city);
Assert.AreEqual("Italy", result.country);
Assert.AreEqual("Lombardy", result.regionName);
Assert.AreEqual("Europe", result.continent);
Assert.IsNotNull(result.lat);
Assert.IsNotNull(result.lon);
Assert.IsNotNull(result.isp);
Assert.IsNotNull(result.zip);
Assert.IsNull(result.continent);
Assert.IsNull(result.district);
Assert.IsNotNull(result.district);
}

[TestMethod]
Expand Down

0 comments on commit f80b35a

Please sign in to comment.