ethtool: add support for private flags #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
approved these changes
Nov 22, 2023
|
We also want to make sure this builds on non-Linux, see the mac build failures. Otherwise seems good so far. |
lorenz
force-pushed
the
add-privflags
branch
from
6e1264d
to
cbdcb31
Compare
|
@mdlayher Added some tests based on ethtool reference values and fixed the MacOS build. |
|
Ah, looks like an easy fix: |
This adds support for geting and setting private flags which are driver-specific (and sometimes even model-specific) controls not part of any generic network settings API. They are used to toggle low-level features in various NICs.
lorenz
force-pushed
the
add-privflags
branch
from
cbdcb31
to
e9c21a3
Compare
|
@mdlayher Fixed, now actually cross-build-tested and passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for geting and setting private flags which are driver-specific (and sometimes even model-specific) controls not part of any generic network settings API.
They are used to toggle low-level features in various NICs.
There are currently no tests in this, considering the driver-specific nature of this I am not sure how to best add some. This has been experimentally tested on Linux 6.1 LTS and seems to work fine.