Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Angular 14 support #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lazybobcat
Copy link

No description provided.

Copy link

@AGDoesCode AGDoesCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will bring the package to support latest Angular.

@JoranLive
Copy link

Hello,
What we are waiting for ?

@sebbousquet
Copy link

@mdlivingston Can you take a look at it when you have time?
Thanks a lot :)

@sebbousquet
Copy link

@mdlivingston Can you tell us if you no longer maintain the repo, we will do our fork in that case

@JoranLive
Copy link

Hi @sebbousquet ,
I suppose that @mdlivingston is not maintain anymore this.
That's life!
May be it could be good to fork ?

@sebbousquet
Copy link

Hi @sebbousquet , I suppose that @mdlivingston is not maintain anymore this. That's life! May be it could be good to fork ?

Yes, I think I will consider this solution soon 😉

@lazybobcat
Copy link
Author

We stopped using this module as our projects are Angular 14 and 15. We use https://www.npmjs.com/package/ngx-mat-select-search instead.

@JoranLive
Copy link

@grothar
Thanks 😉
But we should do a new one for Angular 15...

@tmofardin
Copy link

@JoranLive +1 from me 👍

Copy link

@tmofardin tmofardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge it :)

@hchadli
Copy link

hchadli commented Nov 29, 2023

I got the same issue :

npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@">=9.0.0 <14.0.0" from [email protected]
npm ERR! node_modules/mat-select-filter
npm ERR! mat-select-filter@"2.4.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR! peer @angular/common@">=9.0.0 <14.0.0" from [email protected]
npm ERR! node_modules/mat-select-filter
npm ERR! mat-select-filter@"2.4.1" from the root project

Could you merge your fix or any idea how to bypass this ?

Many thanks

@devLukaszMichalak
Copy link

If anyone is still looking for a solution for the update problem, I made and published a fork that will work with newer Angular versions https://www.npmjs.com/package/@devlukaszmichalak/mat-select-filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants