Firefox 126 removed / Nightly unremoved some moz-prefixed CSS properties #25300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:css
|
I am not sure how to fix the data error here. The first version it is is complaining about predates my change. I also don't want to follow the instruction to remove that preference, since it is an accurate reflection of the code. |
caugner
previously requested changes
Dec 3, 2024
Comment on lines
42
to
48
| "flags": [ | ||
| { | ||
| "type": "preference", | ||
| "name": "layout.css.prefixes.transforms", | ||
| "value_to_set": "true" | ||
| } | ||
| ] |
| @@ -39,7 +39,7 @@ | |||
| { | |||
| "prefix": "-moz-", | |||
| "version_added": "4", | |||
| "version_removed": "preview" | |||
| "version_removed": "126" | |||
There was a problem hiding this comment.
✅ The transition-* changes from here and below LGTM.
|
Thanks! All fixed - and thanks for the explanation. |
caugner
requested changes
Dec 9, 2024
caugner
changed the title
Co-authored-by: Claas Augner <[email protected]>
caugner
approved these changes
Dec 9, 2024
|
Thanks for all the help with this @caugner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the
layout.css.prefixes.transformsprefixed changes made in #21195 to reenable the-mozprefixed transforms:-moz-backface-visibility-moz-perspective-origin-moz-perspective-moz-transform-origin-moz-transform-style-moz-transformThis was done in https://bugzilla.mozilla.org/show_bug.cgi?id=1886134 - I've removed the original nightly changes invisible and replaced it with the preference, since that is what makes most sense.
FF126 also sets the following as false by default (removes the following) as part of adding CSS zoom in https://bugzilla.mozilla.org/show_bug.cgi?id=390936
-moz-transition-delay-moz-transition-duration-moz-transition-property-moz-transition-timing-function-moz-transitionFor those it changes preview to 126.
This fell out of checks in mdn/content#36742