Fix EmbedLiveSample #36052
Merged
Fix EmbedLiveSample #36052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split examples into two live samples for better results windows.
github-actions
bot
added
Content:HTML
|
Preview URLs (comment last updated: 2024-09-25 19:45:34) |
Josh-Cena
reviewed
Sep 25, 2024
OnkarRuikar
pushed a commit
to OnkarRuikar/content
that referenced
this pull request
Sep 28, 2024
* Update index.md Split examples into two live samples for better results windows. * Apply suggestions from code review --------- Co-authored-by: Joshua Chen <[email protected]>
fiji-flo
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Update index.md Split examples into two live samples for better results windows. * Apply suggestions from code review --------- Co-authored-by: Joshua Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split examples into two live samples for better results windows.
Description
When reviewing the results window, I expected to see the results of the previous block of code. Instead, it shows the results of the previous two blocks of code. I mistakenly thought that the nav element in the prose section was converting the prose into a list and rendering that before the prose was rendered. I would show two results windows--one under each code block. I would split the examples apart.
Removed Results heading to simplify the Examples section. Results of markup are shown under their respective code blocks.
When reviewing the Results window, I expected to see the results of the previous block of code. Instead, it shows the results of the previous two blocks of code. I mistakenly thought that the nav element in the prose section was converting the prose into a list and rendering that before the prose was rendered.
Related issues and pull requests
Fixes #36049