-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(http): Refresh headers docs i-r #36079
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:HTTP
HTTP docs
size/l
[PR only] 501-1000 LoC changed
labels
Sep 27, 2024
@bsmth Looks great. A few merged comments, and a few for discussion - all pretty minor |
bsmth
commented
Oct 1, 2024
Co-authored-by: Hamish Willee <[email protected]>
github-actions
bot
added
size/m
[PR only] 51-500 LoC changed
and removed
size/l
[PR only] 501-1000 LoC changed
labels
Oct 1, 2024
bsmth
commented
Oct 1, 2024
github-actions
bot
added
size/l
[PR only] 501-1000 LoC changed
and removed
size/m
[PR only] 51-500 LoC changed
labels
Oct 1, 2024
hamishwillee
reviewed
Oct 4, 2024
This pull request has merge conflicts that must be resolved before it can be merged. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hamishwillee
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much @bsmth - LGTM now!
Super, thank you, Hamish 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refreshes a few HTTP headers pages.
common changes:
The HTTP **`Header-Name`** (request|response) header
in first sentence{{HTTPStatus("406", "406 Not Acceptable")}}
Motivation
Keeping content up-to-date, fixing formatting, unifying writing conventions
Related pull requests: